Re: FS hangups.

On Tue, Jan 29, 2002 at 07:28:58PM +0100, Branko �ibej wrote:
> Branko Cibej wrote:
>
> > cmpilato@collab.net wrote:
>...
> >> #16 0x808bf07 in svn_fs_txn_root (root_p=0xbffff6f4, txn=0x8109818,
> >> pool=0x81348c0) at subversion/libsvn_fs/tree.c:2778
> >> #17 0x808a727 in txn_body_merge (baton=0xbffff768, trail=0x81098e0)
> >> at subversion/libsvn_fs/tree.c:1634
>...
> > I think we need a lower-level API that mimics the public one, except
> > that every function accepts a trail parameter. Calling any public FS
> > api function from within the FS implementation should be absolutely
> > prohibited.
>
> Funny -- IIRC we already *have* such a shadow API, or most of it at
> least ...

Right. It appears that txn_body_merge() should be calling
txn_body_txn_root(). Although that baton is a bit ugly, so we'd refactor
into some kind of helper function.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org