Re: [PATCH] issue #532 read-only admin area

Branko ÄŒibej <brane@xbc.nu> writes:

> --1
>
> I've said before, and I'll say again: Making a file read-only *is not
> the same* as removing write permission bits from the file. This will
> only work on Unix (unless you're using ACLs there, too).
>
>
> The last time this came up I suggested a new set of APR functions that
> deal with write-protection, executableness, archive bits, etc. I still
> think this would be the right thing to do.

A resonable objection, sorry I missed your earlier comment. There
doesn't however appear to be any APR support yet, nobody with Win32
know-how has provided an implementation.

I'll move the code in question into apr_file_set_read_only() in io.c
like so

apr_status_t apr_file_set_read_only (const char *, apr_pool_t *)
{
#ifdef SVN_WIN32
#else
  /* implementation in terms of apr_file_perms_set */
#endif
  return APR_SUCCESS;
}

making the function effectively a no-op on Win32. Thus the admin area
will become read-only on those platforms that are not SVN_WIN32 (which
would have been the case anyway since apr_file_perms_set isn't
implemented on Win32).

-- 
Philip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org