Re: svn system() replacement ?

On Mon, Jan 28, 2002 at 07:00:28PM +0100, Daniel Stenberg wrote:
> On 28 Jan 2002, Karl Fogel wrote:
>
> > In any case, I guess our best course is to leave it as "system()" for now,
> > and file a separate issue explaining what's going on (unless someone wants
> > to change APR right now?).
>
> I still think using the input environment is a better work-around (or even
> Lars Kellogg-Stedman's suggested extern char **eviron approach).
>
> As system() is deemed unportable, then this work-around is probably more
> portable. And it would work today, using the current APR.

I would recommend Philip's point about passing a flag to apr_proc_create()
to tell it to use execv() instead of execve().

Further, we can pass another flag to tell it to search on PATH, meaning that
it should call execvp(). No need for a shell; no need for system().

I'll look into patching up APR; we shouldn't have to hack around this stuff
with a system() call.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org