apr_copy_file and apr_transfer_file_contents

Hello

Subversion defines apr_copy_file and apr_transfer_file_contents in the
file subversion/libsvn_subr/io.c. These functions copy both the file
contents and the file permissions.

Is copying the file permissions a good idea? When a file is created
it can be created with permissions APR_OS_DEFAULT. apr_copy_file and
apr_transfer_file_contents will create a file if necessary but always
set the permissions to match those of the source file. There is no
easy way to restore the default permissions on the destination file.

I can see that at times it might be necessary to atomically copy and
set permissions, so simply removing the permission copying is not a
good idea. I am not sure what the interface should be: perhaps two
functions apr_copy_file and apr_copy_file_contents, or perhaps one
function with a flag.

What is the status of these "apr in subversion" functions?

-- 
Philip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org