Re: svn commit: rev 1067 - trunk/subversion/include trunk/subversion/libsvn_ra_local trunk/subversion/libsvn_client trunk/subversion/mod_dav_svn trunk/subversion/libsvn_repos trunk/subversion/libsvn_ra_dav

On Fri, Jan 25, 2002 at 03:43:37PM -0600, sussman@tigris.org wrote:
>...
> Begin work on network-side of 'svn switch'. I know that we may be
> refactorizing the RA interface later on, but we can still get 'switch'
> working with what we have.

Eh? What is this refactor? What changes in the RA interface are needed?

>...
> * svn_repos.h (svn_repos_begin_report): require new 'switch_path' field.

Eek. That is a "target path" or something. It is not a "switch" path. We
don't want to imply that the path is only for switches. It is a generic
argument to specify a second path for the delta operation.

Please think in the abstract, rather than in your concrete case :-)

>...
> +++ NEW/trunk/subversion/include/svn_repos.h Fri Jan 25 15:43:26 2002
> @@ -121,6 +121,10 @@
> component, used to limit the scope of the update to a single entry
> of FS_BASE, or NULL if all of FS_BASE is meant to be updated.
>
> + SWITCH_PATH is the fs path that the working copy should be
> + transformed into. (In the case of updates, the caller should make
> + sure it's identical to FS_BASE or FS_BASE/TARGET.)

The comment should be independent of the "working copy". This is about
generating a delta which describes a way to change the reported state into a
different PATH/REV.

>...
> + svn_error_t *(*do_switch) (void *session_baton,
> + const svn_ra_reporter_t **reporter,
> + void **report_baton,
> + svn_revnum_t revision_to_update_to,
> + svn_stringbuf_t *update_target,
> + svn_boolean_t recurse,
> + svn_stringbuf_t *switch_url,
> + const svn_delta_edit_fns_t *update_editor,
> + void *update_baton);

It would be nice to not propagate the stringbuf types on new code.

>...
> +++ NEW/trunk/subversion/libsvn_repos/reporter.c Fri Jan 25 15:43:35 2002
>...
> + /* The fs path that will be the 'target' of dir_delta.
> + In the case of 'svn switch', this is probably distinct from BASE_PATH.
> + In the case of 'svn update', this is should be identical to BASE_PATH */
> + const char *switch_path;

We really shouldn't be talking in terms of client operations, but in terms
of what the API actually does/performs.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org