Re: [PATCH REPOST] Trace and canelation editor changes part 4

On Thu, Jan 24, 2002 at 06:28:57PM -0800, Greg Stein wrote:
> On Mon, Jan 21, 2002 at 02:53:10AM -0800, Bill Tutt wrote:
[snip]
> > +static svn_error_t *
> > +should_i_cancel(struct cancel_baton *cb)
> > +{
> > + if (cb->should_i_cancel(cb->inner_baton))
> > + {
> > + return svn_error_create (SVN_ERR_USER_CANCELED,
> > + 0,
> > + 0,
> > + cb->pool,
> > + "User canceled operation.");
>
> The third param is clearer as NULL, since that param is a ptr.
[snip]

Especially since NULL is not guaranteed to be 0. (I think 0 is
a valid pointer on VAX if I remember correctly.)

-- 
Michael Wood <mwood@its.uct.ac.za>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org