Re: text that pops up in your $EDITOR

On Wed, Jan 23, 2002 at 03:55:25PM -0600, Ben Collins-Sussman wrote:
>...
> [NOTE: this increases the memory usage of commits by a small
> amount. We formerly interleaved the discovering and sending of
> local mods, but now discovery will happen first and produce a list
> of changed paths, and then sending the changes will happen entirely
> after that. The benefit is that we preserve commit atomicity even
> when branches are present in the working copy... which is very
> important!]

Well, the only information to collect is the set of "WC roots" rather than
the entire change set.

Then, we can process each WC root, with an interleaved discovery/report.

> Notice, Greg, that this change isn't such a huge deal. It's
> equivalent to running 'svn st' (which currently loads all changed
> paths into memory already), and then piping that list through an
> editor.
>
> Of course, you might argue that 'svn st' is very broken right
> now... but that's a whole new topic. :-)

Yes, I would argue that. In my email, I said:

>> We shouldn't continue to add more and more code that assumes or
>> creates more in-memory buffering of lists of things.

Just because 'svn st' does it, doesn't mean that 'svn commit' should do
it...

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org