Re: raises hand for bite-sized issue #604

Greg Stein wrote:

>On Wed, Jan 23, 2002 at 10:17:41PM +0100, Branko Äibej wrote:
>
>>Greg Stein wrote:
>>
>>>On Wed, Jan 23, 2002 at 04:47:37PM +0100, Branko Äibej wrote:
>>>
>>...
>>
>>>>Ah .. that's SVN_WIN32, already defined in svn_private_config_hw.
>>>>
>>>Why do we have SVN_WIN32 defined, then the compiler will always define
>>>_WIN32 for us?
>>>
>>Why not?
>>
>
>Multiple ways of doing exactly the same thing.
>
>If I see #ifdef SVN_WIN32, then I'm going to wonder how it is different from
>#ifdef WIN32. Do some research and spend the time only to figure out they
>are the same semantics.
>
>Taking your logic to the ridiculous extreme, we could have two names for
>every function in Subversion. You get to choose which one you want to call.
>Wouldn't that be fun? :-)
>
Sure it would be. :-)

Actually, "WIN32" isn't defined by the compiler, it's just something
Vistual Studio sticks by default into the project files. "_WIN32", otoh,
may well be defined by the compiler itself.

Since we won't be able to completely avoid platform-specific code in
Subversion (there are some things that really can't be delegated to
APR), we might as well tell the world we're aware of that and define
SVN_WIN32.

Or even better, we could test for features instead of platform.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org