Re: svn commit: rev 1024 - trunk/subversion/libsvn_client trunk/subversion/tests/clients/cmdline

On Tue, Jan 22, 2002 at 09:46:30PM -0500, Garrett Rooney wrote:
> On Tue, Jan 22, 2002 at 08:49:10PM -0600, Karl Fogel wrote:
>...
> > This kind of worries me. Here we have the two RA layers behaving in a
> > way that a caller of the RA interface can distinguish. That seems
> > like badness -- a sign that something deeper is wrong here. If the RA
> > layer is behaving inconsistently, then people can't just use it based
> > on the docs in svn_ra.h, they have to know more.
>
> See gstein's message today, with the subject:
>
> Re: server diffs and svn diff -rREV1:REV2
>
> It's an issue with either mod_dav_svn or ra_dav (can't recall which),
> and it will be fixed, at which point this can be changed and all will
> be right with the world again...

ra_dav

In the get_file() vtable function, it needs to look at the returned
Content-Type. If a diff is sent back, then ra_dav needs to use a *new*
callback function to get the pristine fulltext that was referenced in its
prior invocation of get_wc_prop(). ra_dav will then take that fulltext,
combine it with the incoming svndiff, and produce a new fulltext which is
shoved into the stream provided to get_file().

Thus, get_file() always returns a fulltext.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org