> From: Garrett Rooney [mailto:rooneg@electricjellyfish.net]
>
> On Tue, Jan 22, 2002 at 01:07:18PM -0800, Bill Tutt wrote:
> > > From: Greg Stein [mailto:gstein@lyra.org]
> > >
> > > If you believe contrary, then outline what the EDITOR concept
means on
> > > Windows. "popping up an editor" just isn't normal Win32 behavior.
> > >
> >
> > Yeah, this is real rats nest for Win32, the easiest way out is to
just
> > use notepad by default for the command line client, or a GUI that
has a
> > text editing control for the commit message. There's nothing wrong
with
> > using the EDITOR environment variable on Win32, it's just very
unlikely
> > that it's actually set to something.
>
> as much as i hate notepad, at least it's always there on windows...
>
> #ifndef WIN23
> editor = apr_getenv("EDITOR");
> #else
> editor = "notepad.exe";
> #end
>
No, you'd want something like:
editor = apr_getenv("EDITOR");
#ifdef WIN32
/* Default to notepad for Win32 folks who don't have an EDITOR value set
*/
if (editor == NULL)
{
editor = "notepad.exe";
}
#endif
No sense in being too restrictive. :)
Bill
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:58 2006