Re: server diffs and svn diff -rREV1:REV2

On Tue, Jan 22, 2002 at 08:35:47PM +0000, Philip Martin wrote:
> Hello
>
> I have a fix for 'svn diff -rREV1:REV2' that copes with the new diffs
> sent over ra_dav. It all works :-) except it breaks ra_local :-(
>
> Consider a file at REV3 in the working copy. When asking for a REV1 to
> REV2 diff, then it appears that ra_dav sends a diff that will
> construct REV2 from REV3, but ra_local sends a diff that will
> construct REV2 from REV1. [When using ra_dav the the
> svn_ra_callbacks_t get_wc_prop function is invoked to determine the
> working copy revision. This doesn't happen over ra_local.]
>
> Am I right in thinking that ra_local sends diffs differently from
> ra_dav?
>
> Now I know how to cause ra_dav to mimic the ra_local behaviour, but
> that is effectively disabling an ra_dav feature. It would also make
> some of my new code redundant, which seems like a waste.

(i haven't looked at this code at all, but...)

why not change ra_local to have the same behavior as ra_dav?

> There doesn't seem to be a way within the editor to determine which
> file is the baseline for the diff, I just have to know. Is passing an
> ra_dav/ra_local flag into the function that creates the editor the
> best way to do this?

that just seems icky... i mean someday there might be more ra layers,
and we dont' want to have to adjust diff to handle all of them... the
whole point of the ra API is that it's supposed to look the same from
the point of view of the client libs.

-garrett

-- 
garrett rooney                     Unix was not designed to stop you from 
rooneg@electricjellyfish.net       doing stupid things, because that would  
http://electricjellyfish.net/      stop you from doing clever things.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org