Re: problem with xml tests

On Mon, Jan 21, 2002 at 02:29:28PM -0500, Garrett Rooney wrote:
> since the changes to support builddir != srcdir in the tests,
> svn-test.sh and svn-test2.sh have been giving me errors. they still
> succeeded, but the shell scripts weren't entirely correct.
>
> i just got a chance to look closer, and it turns out they are passing
> the '==' operator to [, which is not a valid operator on FreeBSD. to
> be portable, we should be using =, not ==.
>
> here's a patch.

+1

Although, I seem to recall that the most portable form is:

if test "$foo" = "bar"; then

The [ ] implies test, but it seems like I heard that some shells don't
understand the brackets. Dunno that you need to worry about that; we've got
a number of other problems if that is the case... :-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org