[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: path canonicalization problem (issue #559)

From: Branko Čibej <brane_at_xbc.nu>
Date: 2002-01-21 00:37:57 CET

Garrett Rooney wrote:

>On Thu, Jan 17, 2002 at 11:13:35PM +0100, Branko _ibej wrote:
>>Karl Fogel wrote:
>>>Hmm. Branko, did your commit of revision 923 fix issue #559?
>>No, I didn't touch those functions, except for ripping out
>>svn_path_*_style. So the problem is probably still there. I can look at
>>it, if you like, but not before Monday.
>i did a little poking around with this a few days ago, and it's not
>now that we've removed the path types, we're back to the problem that
>we pass quite a few url's into svn_path_canonicalize, and we don't
>have any way to determine how to handle them. removing extraneous .'s
>and ..'s isn't too hard, but removing redundant /'s is a bitch,
>because we have to be sure not to wipe out the // in the urls.
>if anyone has a good solution for this, i'd love to hear it. i don't
>want to return to passing path types into all the svn_path functions,
>and having some kind of heuristic to determine what to remove and what
>to leave just seems clunky and prone to failure.
The solution is to use the URI type from APR-UTIL for that. And create
an svn_path_t so that we can tell the difference between paths, URLs and
ordinary strings. Having a single type for all three is error-prone, as
you say.

Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:57 2006

This is an archived mail posted to the Subversion Dev mailing list.