Right. I discovered this the other day, and asked for feedback on it. Ben
supplied that, indicating that 'svn log' and 'svn stat' *should* bail if
they can't talk to the repository. But I wasn't able to get around to
patching this stuff while I was in Chicago this past week.
The simple answer is to change both of those "if" conditions to SVN_ERR(),
and do the similar work in the 'svn log' code.
Cheers,
-g
On Thu, Jan 17, 2002 at 02:47:14PM -0600, cmpilato@collab.net wrote:
> Philip Martin <philip@codematters.co.uk> writes:
>
> > >From add_update_info_to_status_hash()
> >
> > /* Get the RA library that handles URL. */
> > SVN_ERR (svn_ra_init_ra_libs (&ra_baton, pool));
> > if (svn_ra_get_ra_library (&ra_lib, ra_baton, URL->data, pool) != NULL)
> > return SVN_NO_ERROR;
> >
> > /* Open a repository session to the URL. */
> > /* ### if we're supposed to talk to the repos, then it better be there */
> > if (svn_client__open_ra_session (&session, ra_lib, URL, anchor,
> > TRUE, TRUE, auth_baton, pool) != NULL)
> > return SVN_NO_ERROR;
> >
> > What is the rationale for this?
>
> Bugginess. :-)
>
> Seriously, this is just a known wrongness. If the user explicitly
> asks for repos access with -u, and that fails for any reason, the user
> should be told about it.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:57 2006