Re: svn commit: rev 893 - trunk/subversion/libsvn_subr

philip@tigris.org writes:

> * subversion/libsvn_subr/io.c (svn_io_run_cmd): Remove the call to
> apr_procattr_io_set to create pipes, we don't use them. They still
> get created by apr_procattr_child_err_set et.al. but that's an APR
> bug. Fix text of error messages.

Philip,

Ever since this change, I've been seeing funny output. Specifically,
whenever we run 'patch' (which only happens during an textual merge
during updates), I see things like:

   patching file `iota'
   Hunk #1 FAILED at 1.
   1 out of 1 hunk FAILED -- saving rejects to iota.62892.00001.rej
   C ./iota

Instead of the old days, where we simply saw:

   C ./iota

Even when the merge is successful, I no longer just see 'G', but
rather 'Hunk #1 succeeded', and then a 'G'.

So somehow the patch process is dumping stdout to the screen. This is
bad, because it's a subprocess of libsvn_wc. Do you have any idea
what's going on here, or how to fix it?

(Another related mystery: why aren't tests like 'basic_tests.py 5',
which tests merging, choking on the extra output lines?)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:56 2006