[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 885 - trunk/subversion/libsvn_wc

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2002-01-15 01:07:47 CET

Greg Stein <gstein@lyra.org> writes:

> On Mon, Jan 14, 2002 at 05:05:56PM -0600, sussman@tigris.org wrote:
> >...
> > * props.c (svn_wc__save_prop_file): pass APR_TRUNCATE whenever we
> > write out a property file. I can't believe we weren't doing this.
>
> The format of the property files makes it acceptable not truncate. We read
> to the "END" marker, rather than EOF. Thus, if you write a prop file shorter
> than before, you ignore stuff at the end. If you write longer, then the EOF
> == the "END" string.
>
> Truncate is best, but the file format is what has saved us.

Yeah, I just realized today that the file format has been saving our
butts for the last year. But still, it irritated me to see trailing
junk when looking at propfiles.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:56 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.