Re: svn commit: rev 834 - trunk/subversion/libsvn_wc

Philip Martin <philip@codematters.co.uk> writes:
> No. APR_DELONCLOSE unlinks the file. The path cannot then be passed to
> an external process.
>
> I suggest modifying svn_io_open_unique_file() to have a flag that
> causes it to install an apr pool plain cleanup handler to remove the
> file, and an apr pool child cleanup handler to remove the plain
> cleanup handler. Then the files will disappear with the pool and not
> before.

Hmmm... It's not a bad idea, but a little more complexity than we
should be getting into, given that it's not central to the change. I
think for now, we're just going to have all the callers check error
appropriately and clean up the tmp file if necessary.

At a certain point, we do have to admit to ourselves that we're
programming in C here, after all. :-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:56 2006