Re: svn commit: rev 834 - trunk/subversion/libsvn_wc

Greg Stein <gstein@lyra.org> writes:

> Let's make a utility function for this.
>
> I would recommend using APR's APR_DELONCLOSE flag for these files so that we
> can make sure they go away. That would obviate the need for apr_file_remove
> and being careful with exit branches (which Philip noted).

The problem with APR_DELONCLOSE is that (on Unix at least) the file
gets unliked just after creation and so cannot be passed to an
external diff program. Pool cleanup handlers can be used (and diff
does use them) but these need to be removed before invoking the
external diff program because the child process will run it's version
of the handlers. It's painful...

Now if the cleanup handler could determine whether it is the parent or
child, say by using the non-existant apr_process_id(), then the
cleanup handler could be setup to do nothing if the current process ID
didn't match the one it was registered with. Is there a platform
independent concept of process ID?

-- 
Philip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org