Re: svn commit: rev 834 - trunk/subversion/libsvn_wc

Philip Martin <philip@codematters.co.uk> writes:
> If svn_io_copy_and_translate() returns an error neither temporary file
> (that's temp_file_path and tmp_workingfile) will get removed. The pool
> cleanup handler that does temp_file_path elsewhere in the code has to
> be removed before running diff_cmd (see the comments earlier in the
> file). Please arrange for tmp_workingfile to be deleted, and either
> ensure that the pool clean handler is still installed or delete
> temp_file_path.

... and I think a similar comment may apply to my recent changes in
libsvn_wc/questions.c.

Ben and I will take a look at this tomorrow, thanks Philip!

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:56 2006