Re: svn commit: rev 813 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_subr trunk/subversion/libsvn_client trunk/subversion/svnlook

On Thu, Jan 10, 2002 at 05:07:48PM -0600, rooneg@tigris.org wrote:
> Log:
> * subversion/includes/svn_error_codes.h
> (SVN_ERR_EXTERNAL_PROGRAM): new error type for when an external
> program fails in an unexpected way.
> * subversion/include/svn_io.h
> (svn_io_run_diff): new prototype.
> * subversion/libsvn_wc/get_editor.c
> (close_file): use svn_io_run_diff instead of calling diff by hand.
> * subversion/libsvn_subr/io.c
> (svn_io_run_diff): new function that calls diff (via svn_io_run_cmd),
> so we don't have to reproduce the logic all over the place. most of
> this logic comes from libsvn_client/diff.c
> * subversion/libsvn_client/diff.c
> (svn_client__diff_cmd): use svn_io_run_diff instead of calling diff
> by hand.
> * subversion/svnlook/main.c
> (print_diff_tree): ditto.
>
> Approved By: gstein
Two minor nits about the log message.

1) It would be nice if it mentioned the issue number you were fixing.

2) It would be nice to have an overview at the beginning saying something

Raise and error if the configured diff program no longer exists.

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson                    http://www.pilch-bisson.net
     "Historically speaking, the presences of wheels in Unix
     has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~