Re: [Issue 584] - get rid of path styles inside svn

On Thu, Jan 10, 2002 at 10:42:08AM -0600, Karl Fogel wrote:
> Looks good -- really good, you've hit the Right Solution IMHO.
>
> On the question of whether normalization should be done by
> libsvn_client or by its callers, I think I agree with you: since

We can make this decision/discussion seperately from the path conversion
patch.

>...
> Since the path never lengthens, why not use plain `char *' and return
> the number of bytes by which the string was shortened?

Ick. Uck. Oook. -1

>...
> By the way, IMHO normalization should both remove trailing slashes,
> and fold repeated slashes to a single slash. Not sure that has to be
> part of this change, though.

Agreed on all parts.

> Anyway, looks great! I *love* it when code gets smaller... :-)

Hell ya!

> I assume that adding the normalization/denormalization calls to the
> command-line client is intended to be part of the same commit, and
> that you were just waiting to have the Windows build working so you
> could test it there? Anyway, would be good to include that in the
> commit, of course.

IMO, it doesn't have to be the same. Windows /might/ get a little busted as
a result of this patch, but that is somewhat okay. I mean if Branko is happy
with this, then it should definitely be okay.

>...
> > * Adds two new functions, svn_path_normalize and
> > svn_path_denormalize (he he, love those names) that convert

I don't love them. They don't say what they normalizing *to* or *from*. Is
normalize() for creating a native "normalized" path? Or is that for creating
an SVN "normalized" path?

I would much prefer something like: svn_path_internal_style() and
svn_path_native_style().

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org