Ok, Greg and I talked via AIM and came to the following conclusion:
The current print_message function in the UI functions vtable is bad, we
really should eventually be a series of callback functions for each
important event.
Which makes part 3 of the patch sequence an interim step on the way to
finishing off the necessary changes to the trace editors.
So Greg is +1 if I mark up the code with the result of this discussion
so that if anybody else wants to pick up the rest of the work before I
get to it, they can. :)
This way we also don't have to argue about what to do with the stringbuf
issue. :)
FYI,
Bill
> From: Bill Tutt [mailto:billtut@microsoft.com]
>
> > From: Greg Stein [mailto:gstein@lyra.org]
> >
> > On Sun, Dec 23, 2001 at 10:56:21PM -0800, Bill Tutt wrote:
> > > Here is the "move the trace commit, and trace update editors from
> the
> > > command line client and into libsvn_client" patch.
> >
> >
> > IMO, the ui_funcs structure that you introduced should have a wide
> variety
> > of callbacks. You could have a function says thats file_op(op,
> filename)
> > where op is one of ADDED or DELETED or whatever. Or, have
file_added()
> etc.
> > Essentially, pass the relevant data and let the callback do the
> formatting.
> >
>
> I agree, this is just a small part of what will eventually be needed
by
> the trace editors, and this is a small start towards that goal. (small
> patches remember? :) )
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:55 2006