I'm reviewing this right now, Branko. The attached patch didn't have
a log message in it -- I'll continue reviewing, but can you post a log
message for the change? (I know you'd write one when you commit
anyway, but having it makes review so much easier.)
Thanks,
-K
Branko Čibej <brane@xbc.nu> writes:
> I finally managed to create a patch for this issue. It's a bit big, so
> I'd like to ask someone to give it a quick review, and test the
> changes on Unix for me -- I don't have a Unix machine handy for SVN
> development at the moment.
>
> Basically, this patch does the following:
>
> * Removes all traces of svn_path_style from the code
> * Make Subversion use / as the directory separatore internally
> * Adds two new functions, svn_path_normalize and
> svn_path_denormalize (he he, love those names) that convert
> between the local and internal path syntax. These functions aren't
> used anywhere yet, but are intended to be used by the client
> program (*not* libsvn_client) to hammer incoming paths into the
> internal form and outgoing paths (e.g., those coming from trace
> editors) into the local form.
>
> I suspect everything should work as before on Unix.
>
> I'm not sure about Win32 yet -- as long as you don't try to feed it \
> separators, up and st definitely work (better than before), and ci
> should, barring problems in APR, which I'll fix as I come to them.
>
> If everything is O.K. on Unix, I'll try to revive the tests on Win32
> and commit this in about a week -- the sooner the better, as it's a
> bit hard to maintain a patch of this size. The next step is to add
> calls to svn_path_(de)normalize in the appopriate places.
>
>
> --
> Brane Čibej <brane_at_xbc.nu> http://www.xbc.nu/brane/
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:55 2006