Re: new bite-sized task, issue #598

Owen Landgren <olandgren@Macalester.edu> writes:

> @@ -216,10 +217,25 @@
> if ((skip_unrecognized) && (! status->entry))
> continue;
>
> - if (detailed)
> - print_long_format (path, status);
> + if (status->text_status == svn_wc_status_none)
> + {
> + char *message = "svn status: file does not exist:";
> + char *response = NULL;
> + sprintf (response, "%s %s\n", message, path);

Ouch. Not a good idea to go printing characters into unallocated
memory! sprintf is generally bad for Subversion's purposes. Use
apr_psprintf so we can allocate as necessary from the pool.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:55 2006