Re: Trace and cancel update patches part 2

On Sun, Dec 23, 2001 at 10:56:21PM -0800, Bill Tutt wrote:
> Here is the "move the trace commit, and trace update editors from the
> command line client and into libsvn_client" patch.

This patch is dependent upon "part 3" because p3 is needed to remove the
printf() calls introduced into libsvn_client by this patch.

However, p3 also issues formatted strings. Similar to Kevin, I have
reservations about that. In fact, quite serious reservations. I don't think
that libsvn_client should be in the business of formatting anything for the
user.

IMO, the ui_funcs structure that you introduced should have a wide variety
of callbacks. You could have a function says thats file_op(op, filename)
where op is one of ADDED or DELETED or whatever. Or, have file_added() etc.
Essentially, pass the relevant data and let the callback do the formatting.

I believe you responded to Kevin and said "but all clients shouldn't have to
duplicate the formatting". That's bogus. What'll eventually happen is that
some client will have to *parse* that string to figure out what is
happening. Then we're doomed.

So... pending further change or discussion, -1 on parts 2 and 3.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org