Re: new bite-sized task, issue #598

Joseph Dane <jdane@studio3511.com> writes:

> this is my first subversion patch submission. I appreciate any and
> all comments, suggestions, flames, etc.

You betcha.

> Index: ./status.c
> ===================================================================
> --- ./status.c
> +++ ./status.c Wed Jan 9 14:33:55 2002
> @@ -216,10 +216,15 @@
> if ((skip_unrecognized) && (! status->entry))
> continue;
>
> - if (detailed)
> - print_long_format (path, status);
> - else
> - print_short_format (path, status);
> + if (status->text_status == svn_wc_status_none)
> + printf("file does not exist: %s\n", path);

Just a couple of comments here.

First, a minor coding style nit. This file uses spaces between
function calls and '('. That is, it should be 'printf ("file...' just
as you've got it for the rest of your patch.

Secondly, we generally don't print error-ish conditions to the
terminal. Perhaps we should either print nothing for files that don't
exist, or return an appropriate "no such path" svn_error_t.

Whatcha think?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:55 2006