Re: [Patch] configure.in and GNU diff/patch

On Tue, Jan 08, 2002 at 09:36:22PM -0500, Garrett Rooney wrote:
>...
> * subversion/libsvn_wc/get_editor.c
> (close_file): return an error when diff returns an unexpected exit
> code.
> * subversion/libsvn_client/diff.c
> (svn_client__diff_cmd): ditto
> * subversion/svnlook/main.c
> (print_diff_tree): ditto

Those "ditto" calls raise a yellow flag... It would seem to be nice to have
a function that knows about the vagaries of invoking diff, and just Do The
Right Thing. It could simplify a number of the params to get it called, too.
*shrug* Not familiar enough with those sections of code to really know...

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org