[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 763 - trunk/subversion/libsvn_wc trunk/subversion/libsvn_ra_local trunk/subversion/mod_dav_svn trunk/subversion/tests/clients/cmdline

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2002-01-09 01:45:28 CET

sussman@tigris.org writes:

> Modified: trunk/subversion/libsvn_ra_local/update_editor.c
> ==============================================================================
> --- OLD/trunk/subversion/libsvn_ra_local/update_editor.c Tue Jan 8 14:18:22 2002
> +++ NEW/trunk/subversion/libsvn_ra_local/update_editor.c Tue Jan 8 14:18:22 2002
> @@ -96,17 +96,24 @@
> &last_author,
> root, path, subpool));
>
> + /* A root/path will always have a "created rev" field. */
> revision_str = apr_psprintf (subpool, "%ld", committed_rev);
> name = svn_stringbuf_create (SVN_PROP_ENTRY_COMMITTED_REV, subpool);
> value = svn_stringbuf_create (revision_str, subpool);
> SVN_ERR ((*pset_func) (real_baton, name, value));
> -
> - name = svn_stringbuf_create (SVN_PROP_ENTRY_COMMITTED_DATE, subpool);
> - value = svn_stringbuf_create_from_string (committed_date, subpool);
> +
> + if (committed_date)
> + {
> + name = svn_stringbuf_create (SVN_PROP_ENTRY_COMMITTED_DATE, subpool);
> + value = svn_stringbuf_create_from_string (committed_date, subpool);
> + }
> SVN_ERR ((*pset_func) (real_baton, name, value));
>
> - name = svn_stringbuf_create (SVN_PROP_ENTRY_LAST_AUTHOR, subpool);
> - value = svn_stringbuf_create_from_string (last_author, subpool);
> + if (last_author)
> + {
> + name = svn_stringbuf_create (SVN_PROP_ENTRY_LAST_AUTHOR, subpool);
> + value = svn_stringbuf_create_from_string (last_author, subpool);
> + }
> SVN_ERR ((*pset_func) (real_baton, name, value));

If committed_date is null, name and value don't get changed and so
represent SVN_PROP_ENTRY_COMMITTED_REV, which gets sent twice. Then
committed-date will not get removed from the entries file.

Same applies to last_author, leaving last-author in the entries file,
which is what I see with 'svn up -r0'.

-- 
Philip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:55 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.