[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Patch] configure.in and GNU diff/patch (was Re: r727 doesn't build w/ --disable-shared)

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-01-08 20:06:08 CET

Garrett Rooney <rooneg@electricjellyfish.net> writes:
> the error messages given by configure are not as intuitive as they
> could be.... both the error for a bad version of patch and for a bad
> version of diff point you to both the ftp site for patch and the ftp
> site for diff, implying that you need to install both, even if only
> one of them is out of date.
>
> this patch clarifies the errors, and adds a pointer to the FreeBSD
> port for diffutils to the part that notes how FreeBSD uses a hacked
> version of diff.

Applied, thanks! (I removed the spurious "and" from the error message
in the GNU patch section.)

> also, while testing this i noticed that if one deletes the diff binary
> that subversion is compiled to use, it will silently fail when you use
> svn diff. i will investigate this, as it seems like it should be
> throwing some kind of error.

Ooooh, that's bad. Suspect something wrong with the error checking in
this part of libsvn_wc/get_editor.c, but not sure. Let us know what
you find, thanks for looking into this...

         [...]
                  apr_err = apr_proc_create (&diff_proc,
                                             SVN_CLIENT_DIFF,
                                             diff_args,
                                             NULL,
                                             diffproc_attr,
                                             fb->pool);
                  if (! APR_STATUS_IS_SUCCESS (apr_err))
                    return svn_error_createf
                      (apr_err, 0, NULL, fb->pool,
                       "close_file: error starting diff process");
                  
                  /* Wait for the diff command to finish. */
                  apr_err = apr_proc_wait (&diff_proc, NULL, NULL, APR_WAIT);
                  if (APR_STATUS_IS_CHILD_NOTDONE (apr_err))
                    return svn_error_createf
                      (apr_err, 0, NULL, fb->pool,
                       "close_file: error waiting for diff process");
         [...]
                  

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:55 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.