Re: "nasty chmod hack" patch

Mo DeJong <supermo@bayarea.net> writes:
> There is no reason to keep the chmod hack. The reason it was in there
> before was to add execute perms to a shell script, but the patch runs
> a shell script using $(SHELL) instead of executing it:
>
> runprog="$(SHELL) $$progbase"

There is still a reason, Mo -- a lot of people run those tests
directly from the command line, especially when they've written a new
test or fixed an old test. In general, it's always useful to have
runnable programs be +x, for this sort of reason.

> The chmods in autogen.sh could go away once the execute perms are
> under revision control, but it should not matter for Makefile.in. Also,
> the source code might be on a read only media (like a CD) so running
> a chmod on the shell scripts at "make check" time would produce an error.

Um, let's deal with that problem when it comes up.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:53 2006