Re: PATCH: using the env-var http_proxy

On Fri, Dec 21, 2001 at 12:45:37PM -0600, cmpilato@collab.net wrote:
>...
> We've been around this topic of proxies a couple of time before. Here

Yah... there is an open issue on it, which is marked post-1.0 (by Karl, I
believe?). I think it should be fixed for 1.0, really.

>...
> I do *not*, however, want to see "getenv" inside our libraries. This
> kind of thing is completely client-specific, and therefore should be
> ascertained by the client itself, and delivered to the appropriate
> libraries for use via an appropriate public API.

Agreed. I like Karl's apr_get_http_proxy() idea.

>...
> - two (2) additions to the svn_cl__optstate_t structure in the
> command-line client called `proxy_machine' and `proxy_port'.

'proxy_host' and 'proxy_port'

But then you also forgot 'proxy_user' and 'proxy_password'. Of course, you
might also be authenticating via NTLM with your proxy, but we'll leave that
nastiness to Neon :-). We *do* need to give it four pieces of information,
though: user, password, host, port.

>...
> And you know what? I probably could have written the code in less
> time than it took to write this mail.

And because you lacked the user/pass, it would not have been right :-)

Personally, I don't feel a working copy is going to (necessarily) be
portable. I'm not sure what all is going to be in there which will be
non-portable, but newline handling is one. user/pass might not be desirable,
but it would certainly not create portability issues.

Regarding implementation: we would need to pass proxy host/port into RA (or
more specifically: ra_dav), and then have a proxy_userpass authenticator.

Note that proxy host/port can come from APR, and it can also be supplied by
a .svnrc file (or an /etc/svn.rc type thing).

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org