> Greg Stein wrote:
>
> > Instead of this, let's just write a Python script that checks its own
> > version and exits with 0 or 1. I think this should do the trick:
>
> That is much better that what I had, adding it to revised patch.
So, after applying this patch to my working copy, running
autogen.sh/configure/make check, I have to ask the following question:
Mo, did you even *try* your own patch before submitting it?
Read on.
> Index: Makefile.in
> ===================================================================
> --- .svn/text-base/Makefile.in.svn-base Wed Dec 5 06:57:05 2001
> +++ Makefile.in Thu Dec 13 06:49:40 2001
> @@ -117,6 +117,7 @@
> @logfile=`pwd`/tests.log ; \
> echo > $$logfile ; \
> failed=no ; \
> + $(PYTHON) $(top_srcdir)/pycheck.sh ; \
> list='$(TEST_PROGRAMS) @FS_TEST_PROGRAMS@'; for prog in $$list; do \
> chmod a+x $$prog ; \
> progbase=`echo $$prog | sed 's?.*/??'` ; \
Here, you are going to run a script in the top-level Subversion
directory called "pycheck.sh". That's great, except that there's
*not* a pycheck.sh. Your patch creates pycheck.PY (emphasis added).
> Index: configure.in
> ===================================================================
> --- .svn/text-base/configure.in.svn-base Wed Dec 5 06:57:03 2001
> +++ configure.in Thu Dec 13 06:49:41 2001
> @@ -258,13 +258,17 @@
> AC_DEFINE_UNQUOTED(SVN_PATH_STRIP_TRAILING_SLASHDOT, 0,
> [Non-zero if the trailing /. in paths should be stripped])
>
> -dnl Find a python binary, refer
> +dnl Find a python 2.X binary, test cases will not run with Python 1.X
>
> AC_PATH_PROG(PYTHON2, python2, none)
> if test "$PYTHON2" = "none"; then
> - AC_PATH_PROG(PYTHON, python, fail-without-python)
> + AC_PATH_PROG(PYTHON, python, none)
> else
> PYTHON=$PYTHON2
> +fi
> +if test "$PYTHON" != "none"; then
> + echo "checking for Python 2.0 or newer"
> + ${SHELL} ${abs_srcdir}/pycheck.sh ${PYTHON}
> fi
Here we are again, running the non-existent pycheck.sh. This time, we
seem to be invoking a shell with this pycheck.sh and the path to
`python' as arguments. Shouldn't this just be
$(PYTHON) $(top_srcdir)/pycheck.py ;
Please fix, test, and re-submit your patch so we can get this useful
functionality into the build system.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:53 2006