William Uther <will=subversion@cs.cmu.edu> writes:
> > If newline-style is LF, CR, or CRLF, translate <native newline style>
> > -> <requested newline style>. If we notice any CRs or LFs which aren't
> > part of a native-style newline and aren't part of a requested-style
> > newline, abort the commit. If the commit succeeds, apply the <native
> > newline style> -> <requested newline style> translation to the working
> > copy as well, so that it matches what we would get from a checkout of
> > the new rev.
>
> I don't think this preserves reversability. If a file contains BOTH
> <native-style newline> and <requested-style newline> then you neet to
> abort. If you translate just <native-style newline> then you can't
> undo the transformation - you don't know which newlines need to be
> untransformed.
>
> Stated simply: You should only translate when the newline style is
> entirely consistent. Anything else removes the inconsistency and
> hence loses information.
I think that's what Greg H is saying, he just said it differently. He
didn't mean to tolerate files with mixed line endings, just that if
the modified file happens to *match* the specified ending (i.e., any
conversion that took place was entirely undone by some user tool),
that shouldn't be cause for aborting the commit.
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:53 2006