Mo DeJong <supermo@bayarea.net> writes:
> This is going to keep coming up. We need to point out this very
> common error in a clear way or we will continue to get this
> "bug report" for years to come. This patch should fix the
> problem once and for all.
Hey, Mo.
<diversion>Hm...I just had a strange mental image of late 80s hip-hop
tunes with "Hey...Mo...Hey...Mo...!" cycling in the vocal
backdrop</diversion>
Just some quick notes:
> Index: ./autogen.sh
> ===================================================================
> --- ./.svn/text-base/autogen.sh.svn-base Wed Dec 5 06:57:05 2001
> +++ ./autogen.sh Thu Dec 13 03:58:17 2001
> @@ -6,6 +6,7 @@
> for execfile in gen-make.py \
> dist.sh \
> buildcheck.sh \
> + pycheck.sh \
> ac-helpers/get-neon-ver.sh \
> ac-helpers/gnu-diff.sh \
> ac-helpers/gnu-patch.sh \
> @@ -73,6 +74,13 @@
> #
> # Note: this dependency on Python is fine: only SVN developers use autogen.sh
> # and we can state that dev people need Python on their machine
> +
> +OK=`python -c 'print "OK"'`
> +if test "${OK}" != "OK" ; then
> + echo "Python check failed, make sure python is installed and on the PATH"
> + exit 1
> +fi
> +
Right here, I think the error output should say that we require
*Python 2 or greater* to be in the PATH.
> Index: ./configure.in
> ===================================================================
> --- ./.svn/text-base/configure.in.svn-base Wed Dec 5 06:57:03 2001
> +++ ./configure.in Thu Dec 13 04:00:11 2001
> @@ -258,13 +258,17 @@
> AC_DEFINE_UNQUOTED(SVN_PATH_STRIP_TRAILING_SLASHDOT, 0,
> [Non-zero if the trailing /. in paths should be stripped])
>
> -dnl Find a python binary, refer
> +dnl Find a python 2.X binary, test cases will not run with in Python 1.X
That should be "...run within Python..." :-)
Finally, do we want to repeat this test/warning at 'make check' time?
You know, somebody gets the source, ignores the warning at autogen.sh
time because she doesn't plan to contribute. Then ends up
contributing later and freaks when she runs 'make check' -- in fact,
we could at 'make check' time just skip all the python tests if the
right version of Python isn't detected:
BEGIN commit_tests.py
SKIPPED: Python 2.0 or greater not found.
END commit_tests.py
or something. Thoughts?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:53 2006