Re: [PATCH] Be more helpful when read_entries dies.

On Wed, Dec 12, 2001 at 09:30:25AM -0500, Kevin Pilch-Bisson wrote:
> Thanks Justin. A couple of nits below.

Hopefully, this version should address your concerns. -- justin

(read_entries): When there is a XML parsing error, indicate the
filename in the error.

Index: subversion/libsvn_wc/entries.c
===================================================================
--- subversion/libsvn_wc/.svn/text-base/entries.c.svn-base Mon Dec 10 01:50:05 2001
+++ subversion/libsvn_wc/entries.c Wed Dec 12 22:53:34 2001
@@ -665,9 +665,9 @@
     err = svn_xml_parse (svn_parser, buf, bytes_read,
                          APR_STATUS_IS_EOF(apr_err));
     if (err)
- return svn_error_quick_wrap
- (err,
- "read_entries: xml parser failed.");
+ return svn_error_createf (err->apr_err, 0, err, pool,
+ "read_entries: xml parser failed (%s).",
+ path->data);
   } while (!APR_STATUS_IS_EOF(apr_err));
 
   /* Close the entries file. */

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:52 2006