Re: [PATCH] Be more helpful when read_entries dies.

On Wed, Dec 12, 2001 at 09:30:25AM -0500, Kevin Pilch-Bisson wrote:
> Can you provide a log message stating the changed file/function as described
> in HACKING, and exampled in the commit logs.

Yeah, the IRC people grumbled about that. I pointed out that HACKING
didn't say that the log entries were required for patch submissions.
I think they said they were going to look at clarifying that. =)

> I don't think apr_err is the error we want specify here. This will be 0 most
> of the time meaning we would get a message like:
>
> svn_error: #0 : <No Error>
> read_entries: xml parser failed (filename).
>
> Except when we reach the end of file. Then we would describe an error due to
> an end of file, which would probably be a red-herring.
>
> Instead, I would do something like svn_error_createf (err->apr_err, 0, err, ...

I was just looking at the other createf calls and assumed that was
the way to do it. I didn't realize that err had an apr_err in it. =)

>
> Also note that the style of entries.c has spaces between the function name and
> parenthesis.

Yes, sorry, I need to pay more attention to SVN's code style. =)
-- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:52 2006