Re: Bitesized 576

On Sun, Dec 09, 2001 at 06:25:25PM -0800, Greg Stein wrote:
> On Sun, Dec 09, 2001 at 09:19:50AM -0500, Garrett Rooney wrote:
> > On Sun, Dec 09, 2001 at 05:36:20AM -0600, Karl Fogel wrote:
> > > Grant Bowman <grantbow@svpal.org> writes:
> > > > I'm going to start working on this if nobody else is yet. It's the
> > > > bug where svn commit -F foo.c uses it's own contents as a log message.
> > >
> > > Wonderful!
> > >
> > > Can you note in the issue that you've started?
> >
> > actually, i already started on this, and posted a patch last week.
> > here it is again. (this is my second go after Daniel and Greg S.
> > pointed out all the things wrong with my first try)
>
> The new patch looks good to me. I'm not sure if svn_wc_entry() is the "best
> way" to checked for "is this versioned", but if it works...

i agree that there should probably be a 'is this versioned' function
of some sort, but i was unable to find one.

> When submitting a patch, please submit a log message to go with it. (or did
> you in the prior email? need to go look...)

i included one in my first (incorrect) patch. here's one for this
one. wanted to make sure i hadn't made any dumb mistakes first...

* trunk/subversion/include/svn_error_codes.h

  (SVN_ERR_CL_LOG_MESSAGE_IS_VERSIONED_FILE): add new error type.

* trunk/subversion/client/cmdline/main.c

  (main): check if the log message is under version control and if so, error
out unless the user has specified --force, since it is almost certainly not
what they want to do.

-garrett

-- 
garrett rooney                     Unix was not designed to stop you from 
rooneg@electricjellyfish.net       doing stupid things, because that would  
http://electricjellyfish.net/      stop you from doing clever things.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org