Re: [PATCH] issue 576 (specifying -F without any files to commit)

On Thu, Dec 06, 2001 at 08:06:58AM +0100, Daniel Stenberg wrote:
> On Wed, 5 Dec 2001, Garrett Rooney wrote:
> > If the user specified a log message via -F, but didn't specify any files
> > to commit, error out, because it probably isn't what they wanted to do.
>
> That's not how I interpret issue 576. Isn't that to take things a bit too
> far? I mean, my problem (as I actually made this mistake) wasn't that I could
> do "svn commit -F descfile" to commit everything in the directory, my problem
> was rather that I mistyped the commit message file with the file I was gonna
> commit ("cvs commit -F svn.1"). (Thanks to tab-completion in the shell, its
> very easily done!)
>
> Thus, I would rather say that checking that the commit message is not a
> versioned file is what it takes to prevent the same mistake from happening
> again. At least that's how I see it and that's how I read issue 576.

Right. And the test in Garrett's patch isn't quite sufficient:

$ svn commit -F file1 file2

would "pass" his test (that is: are there any files to commit?), but use
file1 for the commit message, rather than committing both files.

And I agree with Daniel: I would be using "svn commit -F /tmp/msg" quite
often to commit a directory. Specifying no files would be quite common.

[ of course, I will stop using -F once EDITOR functionality arrives ]

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org