[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: static const int variable needs init value

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-12-05 23:09:25 CET

On Wed, Dec 05, 2001 at 12:48:56PM -0500, Greg Hudson wrote:
>...
> (Stylistically, I would favor an explicit "= 0" in most cases where
> you'd use a "static const int" declaration. In this case, though, I
> would actually favor getting rid of the "const", if I couldn't find a
> good way to do without the variable entirely. commit.c is doing
> something really odd with singleton_delete_prop, such that nothing cares
> about its value. Asserting that the value is constant has no particular
> meaning.)

singleton_delete_prop needs to stick around, even if it looks like it isn't
in use now. I was going to use it to record deleted properties in a prop
values hash. However, when I was away in July, Joe added a second hash table
and put deleted props in there. I preferred a single "prop changes" table.

The singleton [hash value] DELETE_THIS_PROP is used to identify the deleted
props.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:51 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.