Re: FW: Berkeley DB 4.0 release

On Wed, Dec 05, 2001 at 04:49:30PM -0500, Mark Benedetto King wrote:
> > > had a chance to look at it yet wrt compatibility issues with svn?
> >
> > I have built subversion against db-4.0.14. I used the following patch,
> > which removes support for db-3.3.11. Other than the version number,
> > the change that affects subversion is the txn_XXX to DB_TXN->txn_XXX
> > change, and since most of these provide a compatibility function, the
> > minimal change is just txn_checkpoint.
>
> Can we hide this in a macro? Something like
>
> #if SVN_FS_WANT_DB_MAJOR > 3
> #define BDB_TXN_CHECKPOINT(e,x,y,z) (e)->txn_checkpoint(e,x,y,z)
> #else
> #define BDB_TXN_CHECKPOINT(e,x,y,z) txn_checkpoint(e,x,y,z)
> #endif

the question isn't 'can we', the question is 'should we'.

IMO, supporting multiple versions of such a complicated and important
library is just a bad idea. the issue isn't the interface change, the
issue is potential bugs in the older version.

i would say either switch or don't, but don't support both.

-garrett

-- 
garrett rooney                     Unix was not designed to stop you from 
rooneg@electricjellyfish.net       doing stupid things, because that would  
http://electricjellyfish.net/      stop you from doing clever things.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org