Could someone look at this? (was: [patch] [Issue 566] Import fails on Win32 due to APR bug/problem)

I've been fighting with import on Win32 for the last half an hour or so,
and was about to post a similar patch :). Barry sent this when everyone
was leaving places for Thanksgiving, so maybe it wasn't noticed.

Sincerely,
Jay Freeman (saurik)
saurik@saurik.com

-----Original Message-----
From: Barry Pederson [mailto:barryp@yahoo.com]
Sent: Wednesday, November 28, 2001 4:16 PM
To: dev@subversion.tigris.org
Subject: [patch] [Issue 566] Import fails on Win32 due to APR
bug/problem

Karl Fogel wrote:

> Barry, can you post the patch to the list along with a log message?
>
> (This avoids possible Issuezilla mangling, too.)

This patch fixes a problem that keeps svn "import" from working Win32.

When apr_read_dir() is called with APR_FINFO_NORM as its "wanted" flag,
APR on a Win32 box returns APR_INCOMPLETE, instead of APR_SUCCESS
because
the APR_FINFO_NORM bitmask includes bits indicating you want dev and
inode
info, and those aren't available on the Win32 platform.

With this patch, Subversion's libsvn_client/add.c and
libsvn_client/commit.c only
ask for name and type info, which is all they really need, it should
work for all
platforms, and is consistent with how apr_read_dir() is called in
libsvn_subr/io.c

     Barry

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:51 2006