[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Clean up svn_client_import interface

From: Yoshiki Hayashi <yoshiki_at_xemacs.org>
Date: 2001-12-03 12:36:09 CET

Remove user argument to svn_client_import. User is
retrieved via auth_baton.

* subversion/include/svn_client.h

(svn_client_import): Remove user.
(svn_client_commit): Fix doc.

* subversion/clients/cmdline/import-cmd.c (cl_import): Adjust
  argument of svn_client_import.

* subversion/bindings/ruby/client.c (cl_import): Adjust
  argument of svn_client_import.

Index: ./subversion/include/svn_client.h
===================================================================
--- ./subversion/include/.svn/text-base/svn_client.h.svn-base Wed Nov 28 21:40:37 2001
+++ ./subversion/include/svn_client.h Sat Dec 1 11:08:00 2001
@@ -257,7 +257,7 @@
  * only for extensibility; pass four NULLs here if you don't need
  * them.
  *
- * Store USER as the author of the commit, LOG_MSG as its log.
+ * Store LOG_MSG as the log of the commit.
  *
  * PATH is the path to local tree being imported. PATH can be a file
  * or directory.
@@ -298,7 +298,6 @@
                                 svn_stringbuf_t *path,
                                 svn_stringbuf_t *url,
                                 svn_stringbuf_t *new_entry,
- const char *user,
                                 svn_stringbuf_t *log_msg,
                                 svn_stringbuf_t *xml_dst,
                                 svn_revnum_t revision,
@@ -311,7 +310,7 @@
    only for extensibility; pass four NULLs here if you don't need
    them.
 
- Store USER as the author of the commit, LOG_MSG as its log.
+ Store LOG_MSG as the log of the commit.
 
    TARGETS is an array of svn_stringbuf_t * paths to commit. They need
    not be canonicalized nor condensed; this function will take care of
Index: ./subversion/libsvn_client/commit.c
===================================================================
--- ./subversion/libsvn_client/.svn/text-base/commit.c.svn-base Thu Nov 29 15:56:46 2001
+++ ./subversion/libsvn_client/commit.c Sat Dec 1 11:06:02 2001
@@ -627,7 +627,6 @@
                    svn_stringbuf_t *path,
                    svn_stringbuf_t *url,
                    svn_stringbuf_t *new_entry,
- const char *user,
                    svn_stringbuf_t *log_msg,
                    svn_stringbuf_t *xml_dst,
                    svn_revnum_t revision,
Index: ./subversion/bindings/ruby/client.c
===================================================================
--- ./subversion/bindings/ruby/.svn/text-base/client.c.svn-base Sat Dec 1 09:54:32 2001
+++ ./subversion/bindings/ruby/client.c Mon Dec 3 20:10:45 2001
@@ -415,7 +415,7 @@
 
   err = svn_client_import (before_editor, before_edit_baton,
                            after_editor, after_edit_baton,
- auth_baton, path, URL, new_entry, "",
+ auth_baton, path, URL, new_entry,
                            log_msg, xml_dst, revision, pool);
   if (err)
     {
Index: ./subversion/clients/cmdline/import-cmd.c
===================================================================
--- ./subversion/clients/cmdline/.svn/text-base/import-cmd.c.svn-base Sat Nov 17 10:37:43 2001
+++ ./subversion/clients/cmdline/import-cmd.c Sat Dec 1 11:08:48 2001
@@ -136,7 +136,6 @@
                               path,
                               url,
                               new_entry,
- "", /* ### todo: pass author */
                               message,
                               opt_state->xml_file,
                               opt_state->start_revision,

-- 
Yoshiki Hayashi
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:51 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.