Re: [PATCH] Make working copies read-only.

Greg Hudson <ghudson@MIT.EDU> writes:
> Unless I'm terribly mistaken, we shouldn't be doing anything like "cp A
> B" when we move files from tmp/text-base to text-base. We should be
> unlinking the target and calling rename().
>
> If we have to do a copy instead of a rename for some reason (such as
> portability), then we should unlink the target first, if we know we
> might be trying to replace a non-writable file.

Is it necessary to unlink the dst before doing a rename()? That's not
crash-proof, though in our case it would probably be okay because "svn
cleanup" would fix it, and "svn cleanup" would be forced because the
wc would be in a locked state.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:50 2006