Re: make check: log_tests.py failed

"Barry Scott" <barry.alan.scott@ntlworld.com> writes:

> > All of our python test scripts are doing this:
> >
> > # The `svntest' module
> > try:
> > import svntest
> > except SyntaxError:
> > sys.stderr.write('[SKIPPED] ')
> > print "<<< Please make sure you have Python 2 or better! >>>"
> > traceback.print_exc(None,sys.stdout)
> > raise SystemExit
> >
> > ...is this not enough?
> >
>
> Personally I'd not use the SyntaxError exception to detect version mismatch.
> You are overloading the exception with two meanings. (1) get a newer
> python and (2) subversion script has a bug in it.

'svntest' is a module that does nothing but declare bunch of routines
as a testing API. It doesn't return errors, unless the interpreter
literally chokes over unrecognized syntax.

> I'd recommend you check for Python 2.1.1 as a min version as its been
> out a while, has binary kits for major platforms and is the maintenance
> version of 2.1.

Why check for 2.1 if we don't need it? I've been using 2.0 to write
the svn python tests for a long time, and I'd hate to force people to
upgrade needlessly.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:50 2006