[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: autogen

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2001-11-27 17:44:35 CET

Michael Mounteney <gate02@landcroft.co.uk> writes:
> May I make some suggestions about the `autogen.sh' script ?
>
> 1. The first line is #!/bin/sh but in fact it uses the Korn shell
> construction $( ... ). Was the script developed on a system on which the
> Korn shell is default ? The first line should be #!/bin/ksh

No, the script is intended to be Bourne, not Korn, for maximum
portability.

Is the construction illegal under Bourne? (I'm wondering why we
haven't gotten bug reports about this yet, considering that Subversion
builds are tested on many different Unix platforms...)

> 2. The script uses constructions of the form
>
> $(which gsometool sometool 2>/dev/null) | head -1
>
> to find what tools are available. On Solaris 8, if a tool be not found,
> `which' generates a line of the form
>
> no gsometool in path1 path2 ....
>
> so it seems that the `search' construction should be
>
> $(which gsometool sometool 2>/dev/null | grep -v '^no ' | head -1
>
> in order to eliminate the report from `which'.

Thanks! This seems like a safe improvement, because it wouldn't hurt
on systems where `which' is silent when the target is not found. I've
committed the change.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:49 2006

This is an archived mail posted to the Subversion Dev mailing list.