[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

property code cleanup

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2001-11-06 17:01:28 CET

While reviewing Philip Martin's recent patch to svn_client_propget(),
I got a closer look at some of our recent property changes. The doc
string for svn_client_propget() left me a little lost as to the
precise form of the return-by-reference.

Eventually I was able to determine that it's using
`apr_table_entry_t'. But that's bad: it forces the property value to
be a `char *', meaning no prop values with nulls in them. We decided
long ago that property *names* didn't have to support binary strings,
but property values are Anything Goes.

Kevin Pilch-Bisson, I think this was your commit 290? Can you fix it
please? Suggest returning them in a hash, where the keys are `char *'
propnames and the values are `svn_string_t *'.


/* Returns an apr_table_t of filenames and property values, in *PROPS,
   allocated in POOL. If TARGET is a file or RECURSE is false, there will
   be only a single element, with key TARGET, and value the value of PROPNAME
   in TARGET. If recurse is true and TARGET is a directory, the *PROPS will
   contain a list of node names and property values for TARGET and all of
   its children. The nodenames will be of rooted from the same place as
   TARGET. */
svn_error_t *
svn_client_propget (apr_table_t **props,
                    svn_stringbuf_t *propname,
                    svn_stringbuf_t *target,
                    svn_boolean_t recurse,
                    apr_pool_t *pool);

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:48 2006

This is an archived mail posted to the Subversion Dev mailing list.