[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 381 - trunk/subversion/mod_dav_svn

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2001-11-02 23:10:58 CET

> Author: gstein
> Date: 2001-11-02 20:53 GMT
> New Revision: 381
>
> Modified:
> trunk/subversion/mod_dav_svn/dav_svn.h
> Log:
> Documentation updates.

Delicious, thanks Greg!

One question:

> +
> +/* register our live property URIs with mod_dav. */
> void dav_svn_register_uris(apr_pool_t *p);

Wow. I know you didn't change the prototype in this commit, only
added a doc string, but now that I look at that prototype, I am way
puzzled. I can see from the code that it's modifying a static const
variable. Never mind the const part (??), what about thread-safeness?

Minor note: At first, I thought maybe there were some properties
hanging off the pool P or something, and the function was affecting
those. That turns out not to be the case, of course. Might be nice
to mention P in the doc string, so that other people won't make the
same wrong turn? Your call.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:47 2006

This is an archived mail posted to the Subversion Dev mailing list.