[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] close extern "C"

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2001-11-01 17:47:53 CET

Applied, thanks Philip!

-K

Philip Martin <philip_martin@ntlworld.com> writes:
> Greg Stein <gstein@lyra.org> writes:
>
> > Note that I believe many of our headers have ordering problems with the C++
> > namespace wrappers. I'm just taking this opportunity to point out the
> > "proper" behavior/coding :-)
>
> Mentioning C++ prompted me to try:
>
> $ find svn/subversion/include -type f -name \*.h | grep -v \\.svn | sed 's/.*/#include "&"'/ > z.cc
> g++ -Isvn/expat-lite -I/usr/local/apache/include -Isvn/subversion/include -Isvn/apr/include z.cc
> z.cc:50: parse error at end of input
>
> Hence the following patch:
>
>
>
> * subversion/include/svn_sorts.h: close extern "C"
> * subversion/include/svn_hash.h: close extern "C"
>
> Index: subversion/include/svn_sorts.h
> ===================================================================
> --- subversion/include/.svn/text-base/svn_sorts.h Sun Oct 28 14:11:44 2001
> +++ subversion/include/svn_sorts.h Tue Oct 30 23:27:39 2001
> @@ -85,6 +85,9 @@
> apr_pool_t *pool);
> #endif /* apr_hash_sorted_keys */
>
> +#ifdef __cplusplus
> +}
> +#endif /* __cplusplus */
>
> #endif /* SVN_SORTS_H */
>
> Index: subversion/include/svn_hash.h
> ===================================================================
> --- subversion/include/.svn/text-base/svn_hash.h Sun Oct 28 14:11:43 2001
> +++ subversion/include/svn_hash.h Tue Oct 30 23:29:20 2001
> @@ -86,6 +86,9 @@
> */
> void *svn_pack_bytestring (size_t len, const char *val, apr_pool_t *pool);
>
> +#ifdef __cplusplus
> +}
> +#endif /* __cplusplus */
>
> #endif /* SVN_HASH_H */
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:47 2006

This is an archived mail posted to the Subversion Dev mailing list.