Re: issue #406 patch 2

Matt Kraai <kraai@alumni.carnegiemellon.edu> writes:

> * subversion/include/svn_fs.h
>
> (svn_fs_txn_prop, svn_fs_node_prop, svn_fs_revision_prop):
> Convert propname to const char * and value_p to svn_string_t **.

[...]

> * subversion/libsvn_fs/proplist.c
>
> (svn_fs__get_prop): Convert name to const char * and value_p to
> svn_string_t **.
>
> * subversion/libsvn_fs/proplist.h
>
> (svn_fs__get_prop): Convert name to const char * and value_p to
> svn_string_t **.
>
> * subversion/libsvn_fs/txn-table.c
>
> (struct txn_prop_args, svn_fs_txn_prop): Convert propname to
> const char * and value_p to svn_string_t ** and update call to
> svn_fs__get_prop.
>
> * subversion/libsvn_fs/tree.c
>
> (struct node_prop_args, svn_fs_node_prop): Convert propname to
> const char * and value_p to svn_string_t ** and update call to
> svn_fs__get_prop.
>
> * subversion/libsvn_fs/rev-table.c
>
> (struct revision_prop_args, svn_fs_revision_prop): Convert propname to
> const char * and value_p to svn_string_t ** and update call to
> svn_fs__get_prop.

[...]

---
Just a quick concern here, before I review this in great depth.  I may
be completely off my rocker here (it's been a long week...oh God, it's
only Tuesday...kill me now), but would I be incorrect in recalling
that we wanted counted strings for property names and values so we
could have binary contents for both?
I'm certain that we want binary property values.  It's the property
names I'm not sure of.  Dev-list, are you out there?  Please let me
know (gently, I'm very fragile :-) whazzup with our intended property
support.
Thanks.  Other than that concern, an initial application of the patch
seems to go over relatively smoothly--got one conflict due, I think,
to Karl's reorg of the `svn log' codepath, and one missed instance in
fetch.c of a call to svn_xml_escape_string() that should now be
svn_xml_escape_stringbuf(), that's it.  Didn't run `make check' yet.
Hm.  Sleepy.  G'night.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org