[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: rev 333 - trunk/subversion/libsvn_ra_local trunk/subversion/clients/cmdline

From: Sander Striker <striker_at_apache.org>
Date: 2001-10-30 18:36:59 CET

> From: Karl Fogel [mailto:kfogel@newton.ch.collab.net]
> Sent: 30 October 2001 18:26
> To: Greg Stein
> Cc: dev@subversion.tigris.org
> Subject: Re: svn commit: rev 333 - trunk/subversion/libsvn_ra_local
> trunk/subversion/clients/cmdline
>
> Would like some other's opinions on this (apparently, at least one
> other person was not confused by the byte count).
>
> I understand what you're saying about how machine-oriented information
> doesn't belong in user output. On the other hand, Subversion has
> always been trying to use the same output format for both humans and
> machines wherever possible, because it's a simplicity and maintenance
> win -- that is, if the readability compromises aren't too great.
> Right now, IMHO, the compromise is fairly slight, and worth the gains.
>
> Adding a space before every line has its own disadvantages -- what if
> people were trying to be careful about rightmost column? -- and using
> a rich output format is worse (imagine the quoting complexity *that*
> might introduce, for certain log messages), IMHO. The byte count at
> least leaves the log message itself untouched.

Hmmm, I can live with prefixing each line with a space. If people are
carefull about rightmost column, let them use col 79 istead of 80 (nrs
are just an example).

The other solution I can think of is escaping the seperator (by prefixing
it with a space) if it is found in the log msg.

And, finally, the simplest solution, change the "bytes" label to "msg size"
or something like that.

> So we're +1 + -1 == 0 right now, hmmm, would like others' thoughts on
> this.

> -K

Sander

> Greg Stein <gstein@lyra.org> writes:
> > I've seen it to, so I believe it. But a byte count for *user*
> output isn't
> > the right solution.
> >
> > > So we cannot depend on the separator. The byte count is not so
> > > confusing, really (I mean, were *you* confused, or are you just
> > > assuming that other people might get confused?).
> >
> > Yes. I got confused. Maybe I'm an old fart who's going senile,
> but I saw "%d
> > bytes" and went "wtf?". Then I saw the strlen(msg) and went "huh?!". And
> > then finally it dawned on me the purpose of that field.
> >
> > I like the idea of indenting each line by one space, keeping the -----
> > marker, and dropping the byte count.
> >
> > Or, creating a rich output format.
> >
> > Cheers,
> > -g
> >
> > --
> > Greg Stein, http://www.lyra.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:46 2006

This is an archived mail posted to the Subversion Dev mailing list.